static route expiry feature support in 202012 #12865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging a7499c3 into 3c88bee - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
7 tasks
github-actions bot
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 29, 2023
Need to revert a series of commits: ``` ddb10c4 2022-11-25 | solution refine [jcaiMR] 42af278 2022-11-19 | fix thread exist when key not exists [jcaiMR] 5e80ab5 2022-11-16 | add static route expiry support [jcaiMR] ``` due to below reasons: 1. The commits are not "squash merged", so the prefix "Merged PR XXXX" is missing in commit title. 2. These commits are equal to a combined commit in public repo, which will block public/202012->internal-202012 auto merging ``` fe96679 2022-11-30 | static route expiry feature support (sonic-net#12865) [jcaiMR] ``` So reverting them and wait for auto merging to re-introduce the code to the target branch.
github-actions bot
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 29, 2023
…rnal-202012 branch Related work items: sonic-net#2108, sonic-net#2560, sonic-net#9486, sonic-net#12325, sonic-net#12626, sonic-net#12739, sonic-net#12835, sonic-net#12836, sonic-net#12865, sonic-net#12880, sonic-net#12903, sonic-net#12914, sonic-net#12922, sonic-net#12925, sonic-net#12930, sonic-net#12989, sonic-net#12990, sonic-net#13006, sonic-net#13014, sonic-net#13040, sonic-net#13092, sonic-net#13124, sonic-net#13132, sonic-net#13146, sonic-net#13157, sonic-net#13168, sonic-net#13175, sonic-net#13177, sonic-net#13182, sonic-net#13188, sonic-net#13226, sonic-net#13233, sonic-net#13244, sonic-net#13249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static route expiry feature support in 202012. This is double commit job from master to 202012.
Why I did it
Modify BgpCfgD to support static route expiry
How I did it
Add a new class StaticRouteTimer to monitor old and unrefreshed static routes in APP DB and remove them
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
New key/value in appl_db:
sonic-db-cli APPL_DB hmset 'STATIC_ROUTE:default:5.5.5.0/24' nexthop 10.0.0.27 expiry 'false'
sonic-db-cli APPL_DB hmset 'STATIC_ROUTE:default:5.5.5.0/24' nexthop 10.0.0.27 expiry 'true' refresh 'true'
sonic-db-cli APPL_DB hmset 'STATIC_ROUTE:default:2001::1/64' nexthop 2002::1 expiry 'false'
sonic-db-cli APPL_DB hmset 'STATIC_ROUTE:default:2001::1/64' nexthop 2002::1 expiry 'true' refresh 'true'
expiry == 'false' means non-persistent static route, but will never expire in APPL_DB
refresh == 'true' means non-persistent static route and will be timeout under the control of STATIC_ROUTE_EXPIRY_TIME specified timeout value.